CustomAvailability: avoid exposing the synthesized function for dynamic availability checking as an API entry #85405
+78
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkcsgexi
requested review from
Xazax-hun,
beccadax,
egorzhdan,
ian-twilightcoder,
j-hui,
susmonteiro and
tshortli
as code owners
Contributor
Author
|
@swift-ci please smoke test |
nkcsgexi
force-pushed
the
serialization-dynamic-check
branch
from
48a7d5b to
f14d56e
Compare
Contributor
Author
|
@swift-ci please smoke test |
1 similar comment
Contributor
Author
|
@swift-ci please smoke test |
nkcsgexi
force-pushed
the
serialization-dynamic-check
branch
from
f14d56e to
28a1476
Compare
Contributor
Author
|
@swift-ci please smoke test |
nkcsgexi
force-pushed
the
serialization-dynamic-check
branch
from
28a1476 to
cf40ff5
Compare
nkcsgexi
force-pushed
the
serialization-dynamic-check
branch
from
cf40ff5 to
b3246a4
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please smoke test |
nkcsgexi
force-pushed
the
serialization-dynamic-check
branch
from
b3246a4 to
9c2568f
Compare
Contributor
Author
|
@swift-ci please smoke test |
…ic availability checking as an API entry For dynamic features defined from a header, we synthesize a pure Clang function to check whether the feature should be enabled at runtime. Swift modules don't have capability to deserialize this clang predicate function, leading to crasher as a result. This change fixes the crasher by hiding the synthesized function to be a module internal one. rdar://164410957
nkcsgexi
force-pushed
the
serialization-dynamic-check
branch
from
9c2568f to
e31c1cc
Compare
nkcsgexi
changed the title
Contributor
Author
|
@swift-ci please smoke test |
artemcm
approved these changes
Nov 10, 2025
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For dynamic features defined from a header, we synthesize a pure Clang function to check whether the feature should be enabled at runtime. Swift modules don't have capability to deserialize this clang predicate function, leading to crasher as a result. This change fixes the crasher by hiding the synthesized function to be a module internal one.
rdar://164410957