CustomAvailability: avoid exposing the synthesized function of dynamic availability checking as an API entry

When exposing the function body of the synthesized function that checks whether a dynamic domain is available, the
downstream client may hit a deserialization issue.

Author: nkcsgexi

lib/ClangImporter/SwiftDeclSynthesizer.cpp

@@ -3183,9 +3183,7 @@ FuncDecl *SwiftDeclSynthesizer::makeAvailabilityDomainPredicate(
       BuiltinIntegerType::get(1, ctx), ImporterImpl.ImportedHeaderUnit);
   funcDecl->setBodySynthesizer(synthesizeAvailabilityDomainPredicateBody,
                                (void *)var);
-  funcDecl->setAccess(AccessLevel::Public);
-  funcDecl->addAttribute(
-      new (ctx) ExportAttr(ExportKind::Implementation, /*IsImplicit=*/true));
+  funcDecl->setAccess(AccessLevel::Internal);
 
   ImporterImpl.availabilityDomainPredicates[var] = funcDecl;
 

test/Availability/Inputs/AvailabilityDomains.h

@@ -0,0 +1,28 @@
+#include <availability_domain.h>
+
+int dynamic_domain_pred();
+
+CLANG_ENABLED_AVAILABILITY_DOMAIN(EnabledDomain);
+CLANG_DISABLED_AVAILABILITY_DOMAIN(DisabledDomain);
+CLANG_DYNAMIC_AVAILABILITY_DOMAIN(DynamicDomain, dynamic_domain_pred);
+
+#define AVAIL 0
+#define UNAVAIL 1
+
+__attribute__((availability(domain : EnabledDomain, AVAIL))) void
+available_in_enabled_domain(void);
+
+__attribute__((availability(domain : EnabledDomain, UNAVAIL))) void
+unavailable_in_enabled_domain(void);
+
+__attribute__((availability(domain : DisabledDomain, AVAIL))) void
+available_in_disabled_domain(void);
+
+__attribute__((availability(domain : DisabledDomain, UNAVAIL))) void
+unavailable_in_disabled_domain(void);
+
+__attribute__((availability(domain : DynamicDomain, AVAIL))) void
+available_in_dynamic_domain(void);
+
+__attribute__((availability(domain : DynamicDomain, UNAVAIL))) void
+unavailable_in_dynamic_domain(void);

test/Availability/availability_custom_domains_clang_serialization.swift

@@ -0,0 +1,43 @@
+// REQUIRES: swift_feature_CustomAvailability
+// RUN: %empty-directory(%t/mod)
+// RUN: %target-swift-frontend -emit-module %s -o %t/mod/Foo.swiftmodule -parse-as-library -enable-library-evolution -module-name Foo -import-bridging-header %S/Inputs/AvailabilityDomains.h -enable-experimental-feature CustomAvailability -D FOO
+// RUN: %target-swift-frontend -emit-module %s -o %t/mod/Bar.swiftmodule -parse-as-library -enable-library-evolution -module-name Bar -import-bridging-header %S/Inputs/AvailabilityDomains.h -enable-experimental-feature CustomAvailability -I %t/mod -D BAR
+
+#if FOO
+
+@available(DynamicDomain)
+public struct X {
+    public init() { }
+}
+
+public struct Z {
+    public init() {
+        if #available(DynamicDomain) {
+            print("#available")
+            print(X())
+        } else {
+            print("#unavailable")
+        }
+    }
+}
+
+#endif
+
+#if BAR
+
+import Foo
+
+public struct Y {
+    init() {
+        if #available(DynamicDomain) {
+            print("#available")
+            print(X())
+            print(Z())
+        } else {
+            print("#unavailable")
+            print(Z())
+        }
+    }
+
+}
+#endif

test/SILGen/availability_query_custom_domains_clang.swift

@@ -101,7 +101,7 @@ public func testIfAvailableDynamicDomain() {
 }
 // CHECK: end sil function '$s4Test28testIfAvailableDynamicDomainyyF'
 
-// CHECK-LABEL: sil non_abi [serialized] [ossa] @$sSC33__swift_DynamicDomain_isAvailableBi1_yF : $@convention(thin) () -> Builtin.Int1
+// CHECK-LABEL: sil hidden [ossa] @$sSC33__swift_DynamicDomain_isAvailableBi1_yF : $@convention(thin) () -> Builtin.Int1
 // CHECK: bb0:
 // CHECK:   [[QUERY_FUNC:%.*]] = function_ref @$sSo27__DynamicDomain_isAvailableSbyFTo : $@convention(c) () -> Bool
 // CHECK:   [[QUERY_RESULT:%.*]] = apply [[QUERY_FUNC]]() : $@convention(c) () -> Bool