-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ro] feature /content/docs/concepts/glossary.md #8093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@chalin Hi, is this last failed error for check links related to false positives? Most of the pages are not yet translated into Romanian, they are linked as per the English version. Please advise, thank you! |
Hi. No, these are real failures. If you inspect the log at https://github.com/open-telemetry/opentelemetry.io/actions/runs/18516852373/job/52769038456?pr=8093, you'll see that it's complaining about missing Header IDs (hashes): |
|
@chalin Hi, I'm trying to fix the Check Links errors, but the error details point me to some other languages files. I'm blocked in this PR and I'm not sure how to fix this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @didiViking!
I can see what is happening here, there are a few things you should do to address the issue with the links, I'll leave some inline comments.
|
Feel free to reorder the headings alphabetically as well, it helps keep the glossary consistent and easier to navigate. 🙂 |
|
@vitorvasc Thank you for the tips and examples. Now I fixed all missing Header IDs and it's failing due to some Portuguese broken links. Any ideas? |
I don't see the Portuguese broken links in the history, could you share which ones you're referring to? From what I can see in the last run, there are still three remaining errors in |
I corrected "receptors" but both "distributions" and "signals" are in the plural form in this error but in singular form in the original Header. I tried adding both plural and singular forms and the CI/CD it's still complaining. |
|
@vitorvasc @theletterf |
|
@vitorvasc All checks passed, I added all original links at the bottom of the text. Could you please review? I still need to pass this through a Romanian content review. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few inline suggestions, that should cover all the link labels now. Let me know if you have any questions 🙂
|
@vitorvasc I applied all changes, please review. I'll ask the Romanian team to review the content. Thank you! |
Related to #8088