-
Notifications
You must be signed in to change notification settings - Fork 1.4k
🌱 enhance mhc events #12930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🌱 enhance mhc events #12930
Conversation
Signed-off-by: nayuta-ai <nayuta723@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @nayuta723. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| m, | ||
| corev1.EventTypeNormal, | ||
| EventRemediationTriggered, | ||
| "Triggered remediation for unhealthy Machine %s", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remediation is not triggered by MHC, MHC only marks the machine as unhealthy (as well as it unmarks it in case it goes back to healthy).
Also, I would not add the name of the machine to an event added to the machine itself, it is redundant. May be, let's consider instead to track which MHC instance applied the event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as well as it unmarks it in case it goes back to healthy
Should I handle this as well?
Signed-off-by: nayuta-ai <nayuta723@gmail.com>
What this PR does / why we need it:
#11944 (comment)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #11944
/area machinehealthcheck