Skip to content

Commit 1bd0780

Browse files
committed
Improve MachineHealthCheck event messages
Signed-off-by: nayuta-ai <nayuta723@gmail.com>
1 parent 5e6992d commit 1bd0780

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

internal/controllers/machinehealthcheck/machinehealthcheck_controller.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -535,16 +535,15 @@ func (r *Reconciler) patchUnhealthyTargets(ctx context.Context, logger logr.Logg
535535
t.Machine,
536536
corev1.EventTypeNormal,
537537
EventMachineMarkedUnhealthy,
538-
"Machine %s has been marked as unhealthy by %s",
539-
klog.KObj(t.Machine),
538+
"Marked as unhealthy by MachineHealthCheck %s",
540539
klog.KObj(t.MHC),
541540
)
542541
// Record event on MachineHealthCheck to track remediation history
543542
r.recorder.Eventf(
544543
m,
545544
corev1.EventTypeNormal,
546-
EventRemediationTriggered,
547-
"Triggered remediation for unhealthy Machine %s",
545+
EventMachineMarkedUnhealthy,
546+
"Observed machine %s is now marked as unhealthy",
548547
klog.KObj(t.Machine),
549548
)
550549
}

internal/controllers/machinehealthcheck/machinehealthcheck_targets.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ const (
4545

4646
// EventMachineMarkedUnhealthy is emitted when machine was successfully marked as unhealthy.
4747
EventMachineMarkedUnhealthy string = "MachineMarkedUnhealthy"
48-
// EventRemediationTriggered is emitted when MachineHealthCheck triggers remediation for an unhealthy machine.
49-
EventRemediationTriggered string = "RemediationTriggered"
5048
)
5149

5250
var (

0 commit comments

Comments
 (0)