-
Notifications
You must be signed in to change notification settings - Fork 117
Feat/observer summary UI #1770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat/observer summary UI #1770
Conversation
…h list and info view; formatting fixes
Introduces logic to capture and set the original size of the player name label, ensuring its height is adjusted appropriately when displaying player information in the observer control bar. This improves UI consistency and prevents layout issues when the label content changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started reviewing this, but this is written by AI without human supervision.
Additionally, I dont think this is the way forward for observer view. There are great overlays made by e.g. Legi look better and provide a lot more information.
|
|
||
| if (cash >= 1000000) | ||
| { | ||
| if ((cash % 1000000) == 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary
| } | ||
| else if (cash >= 1000) | ||
| { | ||
| if ((cash % 1000) == 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unneccesary, displaying 1.0k is perfectly fine
| } | ||
| else | ||
| { | ||
| const float millions = static_cast<float>(cash) / 1000000.0f; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cast not needed
| } | ||
| else | ||
| { | ||
| const float thousands = static_cast<float>(cash) / 1000.0f; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cast not needed


No description provided.