tweak(network): Make VC6 and VS22 builds use different magic values in LAN #1747
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helmutbuhler
added
Enhancement
Skyaero42
reviewed
Oct 26, 2025
xezon
previously approved these changes
Oct 27, 2025
xezon
added
Gen
|
Done |
xezon
reviewed
Nov 5, 2025
| // Original retail value is used for builds with VC6 | ||
| static const UnsignedShort GENERALS_MAGIC_NUMBER = 0xF00D; | ||
| #else | ||
| static const UnsignedShort GENERALS_MAGIC_NUMBER = 0xF00D+1; |
There was a problem hiding this comment.
Thinking about this again, this means new clients will not see retail client, right? That means some players cannot see a group of other players, which may or may not be desirable.
Ideally, all clients would be able to see all other client rooms in the lobby, but not be able to join them if incompatible. There are perhaps tricks we can do to prevent retail clients messing with rooms of new clients. Preventing new clients from joining retail client rooms should be possible.
xezon
added
OngoingDiscussion
xezon
reviewed
Nov 5, 2025
| }; | ||
|
|
||
| // Magic number for identifying a Generals packet. | ||
| #if defined(_MSC_VER) && _MSC_VER < 1300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A different magic value for network messages ensures that VS22 build players (for example GO) won't interfere with retail compatible build players.