Bump cmake minimum version to 3.13 #668
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the minimum cmake version lower than 3.13 will leave policies CMP0079 and CMP0077 unset. This will have conflicts with other projects that use cppzmq with add_subdirectory and that have a dependency on Catch2 as well to fail to compile. Bumping the cmake_minimum_version to 3.13 prevents that.
|
Can cmake_policy be used instead to not break things? |
Pull Request Test Coverage Report for Build 19046429772Details
💛 - Coveralls |
|
I will also work, note that however other policies may still be left unset. What solution do you find more suited for this project? In my opinion bumping the minimum required version is cleaner than defining a set of policies manually. However I do not have a good perspective where cppzmq is used nor the requirements of other projects. Therefore I will implement your suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having the minimum cmake version lower than 3.13 will leave policies CMP0079 and CMP0077 unset. This will have conflicts with other projects that use cppzmq with add_subdirectory and that have a dependency on Catch2 as well to fail to compile.
Bumping the cmake_minimum_version to 3.13 prevents that.