fixStreamGetContentsArgumentError

[shaperman]

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌
Fixed issues

[terabytesoftw]

Please update https://github.com/shaperman/yii2-httpclient/blob/1ad6a6dac66029864f83cc300b24acc5c5dac0b6/.github/workflows/build.yml#L29 to v4 and
https://github.com/shaperman/yii2-httpclient/blob/1ad6a6dac66029864f83cc300b24acc5c5dac0b6/.github/workflows/build.yml#L20 to 5, thks,

[samdark]

That solves the issue but, I think, we have more places like that. I don't particularly like how it was solved in Yii2 in the first place. For Yii3, we did it like the following: https://github.com/yiisoft/files/blob/master/src/FileHelper.php#L71

[terabytesoftw]

That solves the issue but, I think, we have more places like that. I don't particularly like how it was solved in Yii2 in the first place. For Yii3, we did it like the following: https://github.com/yiisoft/files/blob/master/src/FileHelper.php#L71

We should then adapt the best solution, and identify where to apply it to do so.

[samdark]

Current implementation is missing closing of the steam in catch block as well.

[samdark]

@terabytesoftw would you please check why tests fail in master?

[terabytesoftw]

1) yiiunit\extensions\httpclient\StreamTransportTest::testSendError
Undefined variable: stream

/home/runner/work/yii2-httpclient/yii2-httpclient/src/StreamTransport.php:71
/home/runner/work/yii2-httpclient/yii2-httpclient/src/Client.php:233
/home/runner/work/yii2-httpclient/yii2-httpclient/src/Request.php:451
/home/runner/work/yii2-httpclient/yii2-httpclient/tests/TransportTestCase.php:141
phpvfscomposer:///home/runner/work/yii2-httpclient/yii2-httpclient/vendor/phpunit/phpunit/phpunit:51
/home/runner/work/yii2-httpclient/yii2-httpclient/vendor/bin/phpunit:118

2) yiiunit\extensions\httpclient\StreamTransportTest::testInvalidUrl
Undefined variable: stream

/home/runner/work/yii2-httpclient/yii2-httpclient/src/StreamTransport.php:71
/home/runner/work/yii2-httpclient/yii2-httpclient/src/Client.php:233
/home/runner/work/yii2-httpclient/yii2-httpclient/src/Request.php:451
/home/runner/work/yii2-httpclient/yii2-httpclient/tests/TransportTestCase.php:254
phpvfscomposer:///home/runner/work/yii2-httpclient/yii2-httpclient/vendor/phpunit/phpunit/phpunit:51
/home/runner/work/yii2-httpclient/yii2-httpclient/vendor/bin/phpunit:118

[samdark]

Thank you!