Skip to content

* ForceAbsent means a package can be removed even if it has other dependants #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

* ForceAbsent means a package can be removed even if it has other dependants #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/burn/engine/dependency.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,7 @@ extern "C" HRESULT DependencyPlanPackageBegin(
else
{
hr = S_OK;
BOOL fDependenciesWarned = FALSE;

for (DWORD i = 0; i < pPackage->cDependencyProviders; ++i)
{
Expand All @@ -467,7 +468,15 @@ extern "C" HRESULT DependencyPlanPackageBegin(
{
hr = S_OK;

if (!fDependentBlocksUninstall)
if (pPackage->requested == BOOTSTRAPPER_REQUEST_STATE_FORCE_ABSENT)
{
if (!fDependenciesWarned)
{
fDependenciesWarned = TRUE;
LogId(REPORT_STANDARD, MSG_DEPENDENCY_PACKAGE_DEPENDENTS_OVERRIDDEN, pPackage->sczId);
}
}
else if (!fDependentBlocksUninstall)
{
fDependentBlocksUninstall = TRUE;

Expand Down
7 changes: 7 additions & 0 deletions src/burn/engine/engine.mc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1282,3 +1282,10 @@ Language=English
Skipping MSI property '%1!ls!' because condition '%2!ls!' evaluates to %3!hs!.
.


MessageId=701
Severity=Warning
SymbolicName=MSG_DEPENDENCY_PACKAGE_DEPENDENTS_OVERRIDDEN
Language=English
BA requested to uninstall package: %1!ls!, despite dependents:
.