-
Notifications
You must be signed in to change notification settings - Fork 75
feat: add configurable base url to embedded world #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add configurable base url to embedded world #227
Conversation
Signed-off-by: Sree Narayanan <sreeaadhi07@gmail.com>
|
|
@eersnington is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
will add this at the end if Gal approves of this idea or if this will interfere with any other plans of his |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also added sourceURL which might come in handy for better errors Signed-off-by: Sree Narayanan <sreeaadhi07@gmail.com>
|
Hey @Schniz, I was wondering if I can introduce changes to the world spec, specifically local world spec to allow users to configure base URL for queue streams.
Here's the reference issue #201 (comment) where a user had --experimental-https flag enabled but could get workflows to start cause the queue requests hard codes "http" as protocol. I think it would massively improve the DX if users can configure the base URL through either a config or Env vars because the current workaround is hacky at best.
The PR is draft and not complete at all ATM (haven't tested too). I want to introduce changes so the following are possible with local world: