Fix CJS imports for @libsql/client
#332
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #182.
This PR aims to fix CJS imports, something that may be blocking the Drizzle Team from merging drizzle-team/drizzle-orm#4998 due to our CJS import test for
drizzle-orm/libsql. We assume this issue is caused by what is described in #182 which is using the same typings for both ESM and CJS.ATTW was used to verify the new build outputs work in both ESM and CJS.
libsql-coresubpackage:Current
In this PR
libsql-clientsubpackage:In this PR
Changes made
tsupto properly generate .cjs and .d.cts files.libsql-core/src/util.ts.libsql-coreandlibsql-client.tsconfig.build-cjs.json).@libsql/coreinlibsql-client. Had to update as there was a type introduced in 0.16.0 and the build wasn't going to work if I kept@libsql/coreon 0.15.x.