Skip to content

Allow function conversions to @convention(c) in @section expressions #85413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2025
Merged

Allow function conversions to @convention(c) in @section expressions #85413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions lib/Sema/LegalConstExprVerifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,9 +216,18 @@ checkSupportedWithSectionAttribute(const Expr *expr,
if (isa<AbstractClosureExpr>(expr))
return std::make_pair(expr, Closure);

// Function conversions are not allowed in constant expressions
if (isa<FunctionConversionExpr>(expr))
// Function conversions are allowed if the conversion is to '@convention(c)'
if (auto functionConvExpr = dyn_cast<FunctionConversionExpr>(expr)) {
if (auto targetFnTy =
functionConvExpr->getType()->getAs<AnyFunctionType>()) {
if (targetFnTy->getExtInfo().getRepresentation() ==
FunctionTypeRepresentation::CFunctionPointer) {
expressionsToCheck.push_back(functionConvExpr->getSubExpr());
continue;
}
}
return std::make_pair(expr, Default);
}

// Direct references to non-generic functions are allowed
if (const DeclRefExpr *declRef = dyn_cast<DeclRefExpr>(expr)) {
Expand Down
2 changes: 2 additions & 0 deletions test/ConstValues/SectionSyntactic.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ func bar(x: Int) -> String { return "test" }
// function references
@section("mysection") let funcRef1 = foo // ok
@section("mysection") let funcRef2 = bar // ok
@section("mysection") let funcRef3: ()->Int = foo // ok
@section("mysection") let funcRef4: @convention(c) ()->Int = foo // ok

// invalid function references (should be rejected)
@section("mysection") let invalidFuncRef1 = foo()
Expand Down