Skip to content

[Runtime] Don't use write back in EIC retain/release #85403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
+16 −8
Merged

[Runtime] Don't use write back in EIC retain/release #85403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions stdlib/public/SwiftDirectRuntime/RetainRelease.s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,8 @@ Lslowpath_release:
// Save/restore the preservemost registers and call swift_retain.
Lcall_swift_release:
maybe_pacibsp
str x9, [sp, #-0x50]!
sub sp, sp, #0x50
str x9, [sp]
stp x10, x11, [sp, #0x10]
stp x12, x13, [sp, #0x20]
stp x14, x15, [sp, #0x30]
Expand All @@ -207,12 +208,14 @@ Lcall_swift_release:
ldp x14, x15, [sp, #0x30]
ldp x12, x13, [sp, #0x20]
ldp x10, x11, [sp, #0x10]
ldr x9, [sp], #0x50
ldr x9, [sp]
add sp, sp, #0x50
ret_maybe_ab

LbridgeObjectReleaseDirectObjC:
maybe_pacibsp
stp x0, x9, [sp, #-0x50]!
sub sp, sp, #0x50
stp x0, x9, [sp]
stp x10, x11, [sp, #0x10]
stp x12, x13, [sp, #0x20]
stp x14, x15, [sp, #0x30]
Expand All @@ -227,7 +230,8 @@ LbridgeObjectReleaseDirectObjC:
ldp x14, x15, [sp, #0x30]
ldp x12, x13, [sp, #0x20]
ldp x10, x11, [sp, #0x10]
ldp x0, x9, [sp], #0x50
ldp x0, x9, [sp]
add sp, sp, #0x50
LbridgeObjectReleaseObjCRet:
ret_maybe_ab

Expand Down Expand Up @@ -330,7 +334,8 @@ Lslowpath_retain:
// Save/restore the preservemost registers and call swift_retain.
Lcall_swift_retain:
maybe_pacibsp
stp x0, x9, [sp, #-0x50]!
sub sp, sp, #0x50
stp x0, x9, [sp]
stp x10, x11, [sp, #0x10]
stp x12, x13, [sp, #0x20]
stp x14, x15, [sp, #0x30]
Expand All @@ -345,12 +350,14 @@ Lcall_swift_retain:
ldp x14, x15, [sp, #0x30]
ldp x12, x13, [sp, #0x20]
ldp x10, x11, [sp, #0x10]
ldp x0, x9, [sp], #0x50
ldp x0, x9, [sp]
add sp, sp, #0x50
ret_maybe_ab

Lswift_bridgeObjectRetainDirectObjC:
maybe_pacibsp
stp x0, x9, [sp, #-0x50]!
sub sp, sp, #0x50
stp x0, x9, [sp]
stp x10, x11, [sp, #0x10]
stp x12, x13, [sp, #0x20]
stp x14, x15, [sp, #0x30]
Expand All @@ -365,7 +372,8 @@ Lswift_bridgeObjectRetainDirectObjC:
ldp x14, x15, [sp, #0x30]
ldp x12, x13, [sp, #0x20]
ldp x10, x11, [sp, #0x10]
ldp x0, x9, [sp], #0x50
ldp x0, x9, [sp]
add sp, sp, #0x50
ret_maybe_ab

#else
Expand Down