Merge dumped dependency info #897
Conversation
neonichu
requested review from
aciidgh,
jakepetroules,
mhrawdon and
owenv
as code owners
Sources/SWBTaskExecution/TaskActions/BuildDependencyInfoTaskAction.swift
Outdated
Show resolved
Hide resolved
Sources/SWBTaskExecution/TaskActions/BuildDependencyInfoTaskAction.swift
Outdated
Show resolved
Hide resolved
Since swiftlang#874, we are dumping per-target dependency information, this adds a new task which merges these for a given build request. The task is only created if there's at least one target in the graph that will dump dependency information, so should be a no-op for all builds right now. Additionally, this declares the dependency info file as an output of `ValidateDependencies` which I neglected to do in my earlier PR.
neonichu
force-pushed
the
bbuegling/merge-dependency-info-during-build
branch
from
e097892 to
952eece
Compare
|
@swift-ci please test |
|
Looks like the failure in |
| guard let target = $0.configuredTarget?.target as? SWBCore.StandardTarget else { | ||
| return nil | ||
| } | ||
| guard target.sourcesBuildPhase?.buildFiles.isEmpty == false else { |
There was a problem hiding this comment.
Note there are some edge cases where empty targets still do some work (generation of the apple versioning .c file for example), I think there is code somewhere to handle that. If it doesn't hurt, you might just want to not skip based on this.
There was a problem hiding this comment.
You're right that we should handle this, but it seems like today the knowledge only exists inside SourcesTaskProducer and isn't readily accessible? Unless someone knows another way, I think I'd rather address this in a follow-up to keep a refactor of the logic in SourcesTaskProducer separate.
| fatalError("unexpected direct invocation") | ||
| } | ||
|
|
||
| public func createTasks(_ cbc: CommandBuildContext, _ delegate: any TaskGenerationDelegate, dumpDependencyPaths: [Path]) async { |
There was a problem hiding this comment.
dumpDependencyPaths here could probably be cbc.inputs
3 participants
Since #874, we are dumping per-target dependency information, this adds a new task which merges these for a given build request. The task is only created if there's at least one target in the graph that will dump dependency information, so should be a no-op for all builds right now.
Additionally, this declares the dependency info file as an output of
ValidateDependencieswhich I neglected to do in my earlier PR.