Rework ForkId to get rid of ChainForkId and its conversions #3810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeme
commented
Nov 5, 2025
| return | ||
|
|
||
| let forkId = p.forkId() | ||
| if p.lastForkId == forkId: |
Contributor
Author
There was a problem hiding this comment.
For some reason the == here fails with
Expression: x.hash == y.hash
[1] x.hash: Bytes4
[2] y.hash: Bytes4
without the added == here:
status-im/nim-eth@21ba892#diff-fdc22bb681374a71a5a754cf46c5ade4b1c54c35c66f163533e86879bab9228aR190-R193
It shouldn't be needed though, and in fact in testing equals win forkid_test.nim, it does work without the added ==.
Contributor
Author
There was a problem hiding this comment.
Actually, it works without the specific ForkId == added, by adding eth/common/base import in p2p.nim (or exporting base in peer_pool.nim. So I'll go that route.
Depends on order I guess and hitting p2p.nim first,
basically instantiation here https://github.com/status-im/nimbus-eth1/blob/master/execution_chain/networking/p2p.nim#L116 ?
And be more consistent in the naming + use fields as per EIPs
kdeme
force-pushed
the
rework-forkid-chainforkid
branch
from
fc25e4e to
a3639d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And be more consistent in the naming + use fields as per EIPs
relying on status-im/nim-eth#826