proxy: better error handling #3607
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirag-parmar
force-pushed
the
vp-errors
branch
from
941b51d to
c3599d8
Compare
3 tasks
kdeme
reviewed
Nov 13, 2025
Contributor
kdeme
left a comment
kdeme
left a comment
There was a problem hiding this comment.
This PR really changes the current usage of Result into the direction of exceptions to deal with error handling in NVP.
While it does look logically correct (I didn't check everything), and exception handling has been improved a lot with usages of raises and the addition of async raise, we have been mostly going in the other direction in our projects. That is, towards the usage of Result.
For reasoning behind this see also https://status-im.github.io/nim-style-guide/errors.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR rectifies all the improper error handling in verified proxy. For this, it could be seen as a refactoring PR. It additionally also brings in new error definitions that will prove to be useful in the future.
Notes:
CatchableErrorsare now removed by translating them to engine errorsCatchableErroris caught)meta: #3101