Skip to content

removes unused cli flags from proxyrunner #2515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 10, 2025
Merged

removes unused cli flags from proxyrunner #2515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5bd5bcb
removes unused cli flags from proxyrunner
ChrisJBurns Nov 7, 2025
f1a1e35
removes redundant foreground flag
ChrisJBurns Nov 7, 2025
18152be
dont need to check for foreground anymore
ChrisJBurns Nov 7, 2025
fae8fa4
Merge branch 'main' into removes-flags-proxyrunner
ChrisJBurns Nov 8, 2025
5f8deb0
Merge branch 'main' into removes-flags-proxyrunner
ChrisJBurns Nov 10, 2025
76c00e2
Merge branch 'main' into removes-flags-proxyrunner
ChrisJBurns Nov 10, 2025
c59d858
Merge branch 'removes-flags-proxyrunner' of github.com:stacklok/toolh…
ChrisJBurns Nov 10, 2025
20a3876
removes redundant cmd test file
ChrisJBurns Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/thv-operator/controllers/mcpserver_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,7 @@ func (r *MCPServerReconciler) deploymentForMCPServer(
replicas := int32(1)

// Prepare container args
args := []string{"run", "--foreground=true"}
args := []string{"run"}

// Prepare container volume mounts
volumeMounts := []corev1.VolumeMount{}
Expand Down
1 change: 0 additions & 1 deletion cmd/thv-operator/test-integration/mcp-server/mcpserver_controller_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ var _ = Describe("MCPServer Controller Integration Tests", func() {

// Verify container args contain the required parameters
Expect(container.Args).To(ContainElement("run"))
Expect(container.Args).To(ContainElement("--foreground=true"))
Expect(container.Args).To(ContainElement(mcpServer.Spec.Image))

// Verify container ports
Expand Down
149 changes: 0 additions & 149 deletions cmd/thv-proxyrunner/app/execution.go
View file
Open in desktop

This file was deleted.

Loading
Loading