Fail with a useful error message if Gradle is run on JDK < 24 #46818
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
If the JDK version used to compile the software is not compatible with Java 24, the build fails fast with a hint what has gone wrong. This check happens on the 'projectsLoaded' hook. Fix spring-projectsgh-46625 Signed-off-by: BenchmarkingBuffalo <46448799+BenchmarkingBuffalo@users.noreply.github.com>
BenchmarkingBuffalo
force-pushed
the
46625-fail-with-a-useful-error-message-if-gradle-is-run-on-jdk-prior-24
branch
from
c8e9242 to
a6705d5
Compare
Member
|
@BenchmarkingBuffalo thanks for the PR but we'd like to explore another route. I'll update the linked issue accordingly. |
snicoll
added
status: declined
mhalbritter
changed the title
mhalbritter
added
type: task
Contributor
|
Hey @BenchmarkingBuffalo , after some consideration we're happy to accept the pull request. Sorry for the confusion and thanks for your help! |
mhalbritter
pushed a commit
that referenced
this pull request
Nov 17, 2025
See gh-46818 Signed-off-by: BenchmarkingBuffalo <46448799+BenchmarkingBuffalo@users.noreply.github.com>
mhalbritter
added a commit
that referenced
this pull request
Nov 17, 2025
Member
|
This unfortunately seems to break Eclipse. I'm going to revert it until I have a bit more time to investigate. |
Member
|
I am going to close this one as we have a duplicate PR already. |
snicoll
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the JDK version used to compile the software is not compatible with Java 24, the build fails fast with a hint what has gone wrong. This check happens on the
projectsLoadedhook.Fix #46625