Introduce detection of dev source code used in production #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruudk
force-pushed
the
dev-source-in-prod
branch
2 times, most recently
from
1be6249 to
c8180ef
Compare
Author
Author
|
@JanTvrdik @janedbal I'm curious to hear what you think about this change. |
Author
|
@janedbal I know you're probably very busy, but do you have advice to move this forward? Thanks. Happy to make any changes. |
This adds a new error type DEV_SOURCE_IN_PROD that detects when
production code imports classes from dev-only autoload paths.
This prevents runtime failures when for example these dev directories
are left out of the deployment to production.
The feature detects cases like:
- Production code in src/ importing from src-dev/
- Production code importing from tests/ directory
Users can ignore these errors using:
$config->ignoreErrorsOnPackage('src-dev', [ErrorType::DEV_SOURCE_IN_PROD]);
ruudk
force-pushed
the
dev-source-in-prod
branch
from
c8180ef to
b57f588
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new error type
DEV_SOURCE_IN_PRODthat detects when production code imports classes from dev-only autoload paths.This prevents runtime failures when for example these dev directories are left out of the deployment to production.
The feature detects cases like:
src/importing fromsrc-dev/tests/directoryUsers can ignore these errors using: