feat(instance): allow root volume name configuration #3456
+4,169
−1,566
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to configure the root volume's name.
The Instance API generated the original name of a root volume according to the image it's based on, but this name can be changed after the server's creation, which will be done by the
renameRootVolumeIfNeededfunction.The Read function has been modified to fetch volume information from the right source (e.g. the name attribute was always empty for SBS volumes).
In the tests, the check function
serverHasNewVolumewas a too permissive (for examples it didn't raise any error for empty names), so it has been modified to expect the exact name that the Instance API is going to generate, and not just filter out terraform-generated names.Closes #3041