uefi-raw: Add FirmwareVolume{,Block}2Protocol #1503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crawfxrd
commented
Dec 19, 2024
| @@ -0,0 +1,219 @@ | |||
| use crate::firmware_storage::FirmwareVolumeAttributes; | |||
Contributor
Author
There was a problem hiding this comment.
This name is arguably wrong, since it's for EFI_FVB_ATTRIBUTES_2.
crawfxrd
commented
Dec 19, 2024
Ref: UEFI-PI 1.9: III-3.4.1 Firmware Volume2 Protocol Ref: UEFI-PI 1.9: III-3.4.2 Firmware Volume Block2 Protocol Signed-off-by: Tim Crawford <tcrawford@system76.com>
nicholasbishop
approved these changes
Jan 3, 2025
Member
nicholasbishop
left a comment
nicholasbishop
left a comment
There was a problem hiding this comment.
Lgtm, thanks for adding this!
crawfxrd
commented
Jan 3, 2025
Comment on lines
+78
to
+79
| EFI_FV_UNRELIABLE_WRITE = 0, | ||
| EFI_FV_RELIABLE_WRITE = 1, |
Contributor
Author
There was a problem hiding this comment.
Just noticed I forgot to strip the prefix from this one.
crawfxrd
commented
Nov 11, 2025
| num_bytes: *mut usize, | ||
| buffer: *mut u8, | ||
| ) -> Status, | ||
| // TODO: Change to efiapi (https://github.com/rust-lang/rust/issues/100189) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bindings for
EFI_FIRMWARE_VOLUME2_PROTOCOL,EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL, and related data types.Reason: I need to read a raw section of a file (
FV->ReadSection) added in edk2 for Platform GOP Policy driver implementation.Ref: UEFI-PI 1.9: III-3.4.1 Firmware Volume2 Protocol
Ref: UEFI-PI 1.9: III-3.4.2 Firmware Volume Block2 Protocol
Checklist