Skip to content

feat(install): add skip_std flag to allow skipping rust-std installation for custom targets #4587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(install): add skip_std flag to allow skipping rust-std installation for custom targets #4587

wants to merge 1 commit into from
+60 −5

Conversation

@cachebag
Copy link
Contributor

@cachebag cachebag commented Nov 4, 2025

Closes #4442
Revision of #4585

djc
djc reviewed Nov 4, 2025
View reviewed changes
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'm not sure yet how/where the ToolchainSection::skip_std field makes it into the DistOptions?

@cachebag cachebag marked this pull request as draft November 4, 2025 16:49
@cachebag
Copy link
Contributor Author

cachebag commented Nov 4, 2025 •
edited
Loading

@djc

So I'm not sure yet how/where the ToolchainSection::skip_std field makes it into the DistOptions?

Yeah, sorry about that. I think it should be fine now, the flag flows through the chain where it should be applied as options.skip_std = skip_std before being used to skip the component in try_update_from_dist_().

@cachebag cachebag requested a review from djc November 4, 2025 18:04
cachebag
cachebag commented Nov 4, 2025
View reviewed changes
src/cli/rustup_mode.rs
let desc = toolchain.resolve(&cfg.get_default_host_triple()?)?;
let status = cfg
.ensure_installed(&desc, vec![], vec![], None, force_non_host, true)
.ensure_installed(&desc, vec![], vec![], None, force_non_host, true, false)
Copy link
Contributor Author

@cachebag cachebag Nov 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djc I think I might be confused with this one- how do you suggest I handle this? I don't know if it's best here to add an attribute, ignoring it.

Copy link
Contributor

@djc djc Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you mean. Do you have more context on what the problem is/why you're not sure?

Copy link
Contributor Author

@cachebag cachebag Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djc I'm sorry, I think I get it..So if I understand correctly, I'm supposed to remove the extra parameter completely from ensure_installed and only set skip_std on DistOptions in the caller before installation?

@cachebag cachebag marked this pull request as ready for review November 4, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djc djc Awaiting requested review from djc

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rustup won't force-skip unavailable rust-std for targets specified through rust-toolchain.toml

2 participants

@cachebag @djc