Fix mod_module_files false positive for tests in workspaces

[TomFryersMidsummer]

Workspaces don't have their integration tests in tests/ at the root, so this check missed them.

This fixes #11775 for workspaces.

changelog: [mod_module_files]: Fix false positive for integration tests in workspace crates.

[rustbot]

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[miguelpduarte]

Unless I'm misreading this, it seems like it will work for some-path/nested/crates/my-crate/src/tests/ but not for some-path/crates/my-crate/tests/. (I read this as "find the first src directory and then check that it doesn't have tests in any directory under it")

[TomFryersMidsummer]

I think that would be what it would be if I’d used skip_while. My intention here, with take_while, is to ‘find if there’s a tests directory, excluding if it’s under a src directory’.

I think just .any(|c| c == "tests"), without the take_while, would be good enough for almost all cases, but excluding the contents of src seemed like a good way to eliminate a few false positives (for the check, leading to false negatives for the lint).

[miguelpduarte]

You are totally correct - I should have double-checked in the docs, it's been a while since I used take_while and skip_while so I got them mixed up 🤦 Sorry for the confusion!

[miguelpduarte]

Great stuff!

View changes since this review