-
Notifications
You must be signed in to change notification settings - Fork 187
Add APACHE 2.0 and MIT dual-license for RISC-V #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add APACHE 2.0 and MIT dual-license for RISC-V #366
Conversation
|
Can you go through all the |
|
Definitely! tomorrow I will push the changes as requested (since its sleeping time in my country xD) |
|
Finally xD @romancardenas I have updated all the |
romancardenas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Check my comments
riscv-pac/CHANGELOG.md
Outdated
|
|
||
| ### Added | ||
|
|
||
| - Updated the license to `MIT or Apache-2.0` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not add changes within the section of an already released version. Please, create a new ### Changed subsection right below the ##[Unreleased] section.
riscv/CHANGELOG.md
Outdated
|
|
||
| ### Added | ||
|
|
||
| - Updated the license to `MIT or Apache-2.0` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of here, move it to the Changed list (below line 18 in this doc)
Co-authored-by: Román Cárdenas Rodríguez <rcardenas.rod@gmail.com>
Co-authored-by: Román Cárdenas Rodríguez <rcardenas.rod@gmail.com>
Co-authored-by: Román Cárdenas Rodríguez <rcardenas.rod@gmail.com>
|
DONE! @romancardenas all the requested changes have been pushed! thanks for the commits + review. |
romancardenas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes
Co-authored-by: Román Cárdenas Rodríguez <rcardenas.rod@gmail.com>
|
DONE! @romancardenas sorry, from my side as-well, I also overlooked the changes, but thanks for the commit! |
romancardenas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! thanks
45f54d6
|
THANKS! |
This PR adds a LICENSE-APACHE for Apache 2.0 license and LICENSE-MIT for MIT license to wipe out the LICENSE inconsistencies across the repo.
Closes #365