Skip to content

Conversation

@KushalMeghani1644
Copy link
Contributor

This PR adds a LICENSE-APACHE for Apache 2.0 license and LICENSE-MIT for MIT license to wipe out the LICENSE inconsistencies across the repo.

Closes #365

@KushalMeghani1644 KushalMeghani1644 requested a review from a team as a code owner November 5, 2025 08:23
@romancardenas
Copy link
Contributor

Can you go through all the Cargo.toml files in the crates and update their license to "MIT OR Apache-2.0"?

@KushalMeghani1644
Copy link
Contributor Author

KushalMeghani1644 commented Nov 5, 2025

Definitely! tomorrow I will push the changes as requested (since its sleeping time in my country xD)

@KushalMeghani1644
Copy link
Contributor Author

Finally xD @romancardenas I have updated all the Cargo.toml files in the crate and updated their license to MIT OR Apache-2.0 and have fixed all the CHANGELOG.md files. So now this PR now seems ready for review... :)

Copy link
Contributor

@romancardenas romancardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Check my comments


### Added

- Updated the license to `MIT or Apache-2.0`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not add changes within the section of an already released version. Please, create a new ### Changed subsection right below the ##[Unreleased] section.


### Added

- Updated the license to `MIT or Apache-2.0`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of here, move it to the Changed list (below line 18 in this doc)

KushalMeghani1644 and others added 5 commits November 6, 2025 20:46
Co-authored-by: Román Cárdenas Rodríguez <rcardenas.rod@gmail.com>
Co-authored-by: Román Cárdenas Rodríguez <rcardenas.rod@gmail.com>
Co-authored-by: Román Cárdenas Rodríguez <rcardenas.rod@gmail.com>
@KushalMeghani1644
Copy link
Contributor Author

DONE! @romancardenas all the requested changes have been pushed! thanks for the commits + review.

Copy link
Contributor

@romancardenas romancardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

Co-authored-by: Román Cárdenas Rodríguez <rcardenas.rod@gmail.com>
@KushalMeghani1644
Copy link
Contributor Author

DONE! @romancardenas sorry, from my side as-well, I also overlooked the changes, but thanks for the commit!

Copy link
Contributor

@romancardenas romancardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! thanks

@romancardenas romancardenas added this pull request to the merge queue Nov 6, 2025
Merged via the queue into rust-embedded:master with commit 45f54d6 Nov 6, 2025
136 of 139 checks passed
@KushalMeghani1644
Copy link
Contributor Author

THANKS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LICENSE inconsistency across the repo.

2 participants