Remove version check from Redis preflight #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the `INFO` version check from the Redis connection preflighting. In our automated test suite we make extensive use of [`miniredis`](https://github.com/alicebob/miniredis) rather than depending on a full Redis server. Miniredis is quite capable, but does not implement the `INFO` command. Redis 5 was released in 2018 and was a significant upgrade to Redis. I haven't seen Redis < 5 in production since shortly after 5's release. Therefore I believe this to be a reasonable loosening of the constraints on redisqueue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
INFOversion check from the Redis connectionpreflighting.
In our automated test suite we make extensive use of
miniredisrather thandepending on a full Redis server. Miniredis is quite capable, but does
not implement the
INFOcommand.Redis 5 was released in 2018 and was a significant upgrade to Redis. I
haven't seen Redis < 5 in production since shortly after 5's
release. Therefore I believe this to be a reasonable loosening of the
constraints on redisqueue.
@robinjoseph08 I understand if this isn't a change you want to pull in, just thought I'd see if we could continue tracking upstream :).