Add unique function #2166
Open
Add unique function #2166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hmm. This adds some other stuff that we want to contribute from our fork. Will fix it to leave out only the UNIQUE function. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2166 +/- ##
==========================================
- Coverage 99.23% 99.20% -0.04%
==========================================
Files 32 32
Lines 30379 30486 +107
==========================================
+ Hits 30148 30245 +97
- Misses 153 160 +7
- Partials 78 81 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xuri
added
the
size/XL
* Implement UNIQUE function * Reduce memory footprint --------- Co-authored-by: Ivan Hristov <ivan.hristov@abraxa.com>
IvanHristov98
force-pushed
the
add-unique-function
branch
from
e2d0a49 to
b156de9
Compare
Contributor
Author
|
I removed the redundant commits. I also performed a refactoring. |
xuri
requested changes
Nov 17, 2025
| func transposeFormulaArgsMatrix(args [][]formulaArg) [][]formulaArg { | ||
| if len(args) == 0 { | ||
| return args | ||
| } |
Member
There was a problem hiding this comment.
Hi @IvanHristov98, could you grant a push permission on this PR branch for me, I'll add unit test for these uncovered lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Implements the UNIQUE function in excel.
Description
Implements the UNIQUE function in excel.
https://support.microsoft.com/en-us/office/unique-function-c5ab87fd-30a3-4ce9-9d1a-40204fb85e1e
Related Issue
#2165
Motivation and Context
So that I can use UNIQUE in excel. It is a very useful function.
How Has This Been Tested
Unit tests were added. The test cases were derived with the help of the official MS docs and I checked them.
Types of changes
Checklist