Update googletest and googlebench dependencies #337
+27
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryComer
force-pushed
the
update-google-test-and-bench
branch
14 times, most recently
from
3dfeeee to
4cedbc5
Compare
GregoryComer
force-pushed
the
update-google-test-and-bench
branch
from
4cedbc5 to
ca54b78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update googletest to 1.17 (from 1.11) and googlebenchmark to 1.9.4 (from 1.6.1). This is to resolve issues on CMake 4.x complaining about the CMake 3.5 minimum version used in dependencies.
I ran into a naming conflict in the benchmarks with the benchmark functions shadowing the cpuinfo functions they call. I'm not entirely sure why this is a problem after the dep update, but I've added a _bench suffix, which resolves the issue.