Skip to content

Conversation

@zxd1997066
Copy link

@zxd1997066 zxd1997066 commented Nov 13, 2025

This PR is targeted to add common code for UTs on XPU

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3335

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f4eed65 with merge base ff0e461 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 13, 2025
pytest -v -s torchao/test/quantization/quantize_/workflows/int4/test_int4_plain_int32_tensor.py
pytest -v -s torchao/test/quantization/quantize_/workflows/int4/test_int4_plain_int32_tensor.py

pytest -v -s torchao/test/quantization/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does these tests run on xpu?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These UTs will be run on XPU finally. The current TorchAO CI should only cover the CUDA device and skip on XPU. We plan to firstly add these test folders into the XPU ci which is triggered by ciflow/xpu and then enabled the XPU UTs file by file to reduce the review effort.

@liangan1 liangan1 added topic: for developers Use this tag if this PR is mainly developer facing xpu Intel XPU related features ciflow/xpu label used to trigger xpu CI jobs labels Nov 13, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 13, 2025

To add the ciflow label ciflow/xpu please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/xpu label used to trigger xpu CI jobs label Nov 13, 2025
@liangan1 liangan1 added the ciflow/xpu label used to trigger xpu CI jobs label Nov 13, 2025
@pytorch-bot pytorch-bot bot removed the ciflow/xpu label used to trigger xpu CI jobs label Nov 13, 2025
@liangan1 liangan1 added the ciflow/xpu label used to trigger xpu CI jobs label Nov 13, 2025
return decorator


def skip_if_no_xpu(message=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently these things are a bit confusing I think, since I remember some of these work with unittests and others work with pytest. can you confirm what these are working with? I think ideally we should create two versions, one for unittests one for pytest

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created two versions for both unittest and pytest

@pytorch-bot pytorch-bot bot removed the ciflow/xpu label used to trigger xpu CI jobs label Nov 14, 2025
@liangan1 liangan1 added the ciflow/xpu label used to trigger xpu CI jobs label Nov 14, 2025
@pytorch-bot pytorch-bot bot removed the ciflow/xpu label used to trigger xpu CI jobs label Nov 14, 2025
@liangan1 liangan1 added the ciflow/xpu label used to trigger xpu CI jobs label Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/xpu label used to trigger xpu CI jobs CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: for developers Use this tag if this PR is mainly developer facing xpu Intel XPU related features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants