-
Notifications
You must be signed in to change notification settings - Fork 645
Exclude legacy-theme/ts/colors from published package #7144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Update package.json files field to exclude dist/legacy-theme/ts/colors directory from npm package. The colors directory is only used by precompile-color-schemes.ts script and should not be published. The color-schemes.ts file remains published as it is imported by theme.ts. Co-authored-by: siddharthkp <1863771+siddharthkp@users.noreply.github.com>
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
Closes #
The
colorsdirectory underpackages/react/src/legacy-theme/ts/colorscontains individual color scheme files used only byprecompile-color-schemes.tsto generatecolor-schemes.ts. These source files should not be published to npm.Changelog
Changed
filesfield inpackage.jsonto excludedist/legacy-theme/ts/colorsfrom published packageRemoved
Rollout strategy
Non-breaking change. The colors directory was build-time only and not intended for external use.
color-schemes.tsremains published and is the public API.Testing & Reviewing
Verify with
npm pack --dry-runthat:dist/legacy-theme/ts/color-schemes.{js,d.ts}files are presentdist/legacy-theme/ts/colors/are includedMerge checklist
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.