Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 6, 2025

Closes #

The colors directory under packages/react/src/legacy-theme/ts/colors contains individual color scheme files used only by precompile-color-schemes.ts to generate color-schemes.ts. These source files should not be published to npm.

Changelog

Changed

  • Updated files field in package.json to exclude dist/legacy-theme/ts/colors from published package

Removed

  • Removed ~800KB of TypeScript declaration files from published package (colors directory no longer included)

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Non-breaking change. The colors directory was build-time only and not intended for external use. color-schemes.ts remains published and is the public API.

Testing & Reviewing

Verify with npm pack --dry-run that:

  • dist/legacy-theme/ts/color-schemes.{js,d.ts} files are present
  • No files from dist/legacy-theme/ts/colors/ are included

Merge checklist

Original prompt

On package.json, check if packages/react/src/legacy-theme/ts/colors is used anywhere other than precompile-color-schemes.ts.

if not, update files in package.json so that we don't publish packages/react/src/legacy-theme/ts/colors

note: we still need to publish packages/react/src/legacy-theme/ts/color-schemes.ts


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2025

⚠️ No Changeset found

Latest commit: 60c5d14

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Update package.json files field to exclude dist/legacy-theme/ts/colors directory from npm package.
The colors directory is only used by precompile-color-schemes.ts script and should not be published.
The color-schemes.ts file remains published as it is imported by theme.ts.

Co-authored-by: siddharthkp <1863771+siddharthkp@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove unused colors module from package.json Exclude legacy-theme/ts/colors from published package Nov 6, 2025
Copilot finished work on behalf of siddharthkp November 6, 2025 08:02
Copilot AI requested a review from siddharthkp November 6, 2025 08:02
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@siddharthkp siddharthkp added skip changeset This change does not need a changelog and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 6, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants