Fix stack overflow when circular callbacks are displayed on the devtool callback #3490
+13
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaron-Wrote-This
requested review from
T4rk1n,
emilykl and
ndrezn
as code owners
Aaron-Wrote-This
force-pushed
the
bugfix/callback_graph_recursion_on_circular_dependencies
branch
2 times, most recently
from
8c748b1 to
fd083aa
Compare
T4rk1n
reviewed
Nov 4, 2025
Comment on lines
30
to
31
| function ascend(node, collection, visited = new Set()) { | ||
| // FIXME: Should we include State parents but non-recursively? | ||
| if (visited.has(node.id())) { |
There was a problem hiding this comment.
We can remove that fixme comment now.
Aaron-Wrote-This
force-pushed
the
bugfix/callback_graph_recursion_on_circular_dependencies
branch
from
fd083aa to
899a665
Compare
The command ran cleanly, but I'm not sure what it changed. I included that in my push so hopefully it's good now. Thanks for taking a look! |
Looks good, the remaining failure is unrelated, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes stack overflow seen when accessing the Callback Graph when there are circular callbacks present.
Solves: #1656
Contributor Checklist
optionals
CHANGELOG.md