Fix pkgutil.loader removal #3488
Merged
+312
−199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndrezn
approved these changes
Nov 3, 2025
|
@KoolADE85 I had to make a bunch of changes to make the typing tests pass, can you take a final look? |
camdecoster
approved these changes
Nov 6, 2025
There was a problem hiding this comment.
Do you have a convention for using import typing vs. from typing import ...? If so, could you switch to that convention across all these type annotations?
There was a problem hiding this comment.
No conventions, some types are better import from typing_extensions to ensure backward compatibility in which case I prefer the from typing import ... syntax to easily switch between those.
Comment on lines
+575
to
+578
| self.callback_map: dict = {} | ||
| # same deps as a list to catch duplicate outputs, and to send to the front end | ||
| self._callback_list = [] | ||
| self.callback_api_paths = {} | ||
| self._callback_list: list = [] | ||
| self.callback_api_paths: dict = {} |
There was a problem hiding this comment.
Does dict assign the same type as Dict?
There was a problem hiding this comment.
Yes, we still support 3.8 but later versions of Python prefer using that with the list[int] syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreation of #3476 with further fixes
Fix #3139