-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(plugin-mcp): correctly uses local access controls #14457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to scope your PR titles to the package name:fix(plugin-mcp):. @denolfe is adding scopes to our pr-title.yml file right now.
| relationTo: | ||
| typeof pluginOptions.userCollection === 'string' | ||
| ? pluginOptions.userCollection | ||
| : pluginOptions.userCollection?.slug || 'users', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be improved. Since pluginOptions.userCollection is an optional field I am guessing most users won't have it configured. I would want the same fallback handling as we do for the admin user sanitization:
| if (!sanitizedConfig?.admin?.user) { |
Always need to go for lowest amount of config possible and sensibly defaulting as we can.
Fix:
Feat: