TST: Replace ensure_clean utility function with the temp_file in \_testing #62976
+26
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Just use the temp_file fixture, don't use an intermediate tempfile.TemporaryDirectory step. Also if this is AI-generated, we discourage that. |
jbrockmendel
added
the
AI Slop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replace uses of the internal
ensure_cleanhelper with standard temporary-directory semantics in test helpers to avoid leaving open file handles on Windows and to prepare tests for migration to pytest'stemp_filefixture.Files Changed
Changes
ensure_cleanwithtempfile.TemporaryDirectory()in helper functions used by tests.