Skip to content

Conversation

@rm-gh-8
Copy link
Contributor

@rm-gh-8 rm-gh-8 commented Nov 19, 2025

Backporting JDK-8366893: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java timed out on macos-aarch64.

Fixes the timeout issue.

Ran GHA Sanity Checks (passed) and 2 updated tests (passed).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8366893 needs maintainer approval

Issue

  • JDK-8366893: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java timed out on macos-aarch64 (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2484/head:pull/2484
$ git checkout pull/2484

Update a local copy of the PR:
$ git checkout pull/2484
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2484/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2484

View PR using the GUI difftool:
$ git pr show -t 2484

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2484.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2025

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 0dad3f1ae8d0c35c4b7a8188ad7854d01c7cd6b4 8366893: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java timed out on macos-aarch64 Nov 19, 2025
@openjdk
Copy link

openjdk bot commented Nov 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Nov 19, 2025
@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Nov 19, 2025

The difference between the original commit and this PR is the absence of the changes in test/jdk/java/lang/Thread/virtual/stress/GetStackTraceALotWhenBlocking.java. The GetStackTraceALotWhenBlocking.java test is not included in JDK21, so the change was not included.

@rm-gh-8 rm-gh-8 marked this pull request as ready for review November 19, 2025 19:35
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 19, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 19, 2025

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look fine: GetStackTraceALotWhenBlocking isn't in 21u.

@openjdk
Copy link

openjdk bot commented Nov 19, 2025

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@rm-gh-8
Copy link
Contributor Author

rm-gh-8 commented Nov 19, 2025

/approval request for backport of JDK-8366893: java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java timed out on macos-aarch64.

Ran the related tests on macos-aarch64:

(Passed) - make test TEST=java/lang/Thread/virtual/stress/GetStackTraceALotWhenPinned.java 2>&1 | tee macos-aarch64-specific-1-test.log
(Passed) - make test TEST=java/lang/Thread/virtual/stress/ParkALot.java 2>&1 | tee macos-aarch64-specific-2-test.log

Results are attached.
macos-aarch64-specific-1-test.log
macos-aarch64-specific-2-test.log

@openjdk
Copy link

openjdk bot commented Nov 19, 2025

@rm-gh-8
8366893: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants