-
Notifications
You must be signed in to change notification settings - Fork 615
feat: Browser Navigation Instrumentation #3148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Browser Navigation Instrumentation #3148
Conversation
a1fbf7d to
9ef7a8a
Compare
david-luna
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a very good start :)
packages/instrumentation-browser-navigation/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-browser-navigation/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-browser-navigation/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-browser-navigation/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-browser-navigation/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-browser-navigation/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-browser-navigation/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
b4f4f99 to
42bfa43
Compare
packages/instrumentation-browser-navigation/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
packages/instrumentation-browser-navigation/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
overbalance
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would run npx prettier --write packages/instrumentation-browser-navigation as well.
|
@Abinet18 I forgot to mention that you should delete |
489169c to
a8e0c76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw you resolved my comment about the example that relies on an older version of @opentelemetry/resources without responding. The examples don't work because of the deprecated syntax. I realize you didn't introduce that issue, and that all four examples need to be fixed. @martinkuba what do you advise?
I see the examples don't work when I reinstall and start. I have fixed the resource related code in all |
ec553ed to
68d5314
Compare
Which problem is this PR solving?
Creates a new instrumentation for browser navigation, in place of page view instrumentation that was being worked in this PR, with event defined in SemConv for this event
Short description of the changes