-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: add instrumentation for AsyncHttpClient version 1.8 #15195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I believe that some code could be shared between 1.8 and 1.9 instrumentations. |
Yes, but the code isn't extensive. There are a few differences in |
you could name the common module
You could pass a helper class to these that abstracts away the part that is different between async http client versions. |
|
🔧 The result from spotlessApply was committed to the PR branch. |
No description provided.