-
Notifications
You must be signed in to change notification settings - Fork 700
otelconf: Increased test coverage for Prometheus-related code #7440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7440 +/- ##
=======================================
+ Coverage 80.1% 81.0% +0.8%
=======================================
Files 191 194 +3
Lines 12289 13073 +784
=======================================
+ Hits 9850 10593 +743
- Misses 2076 2103 +27
- Partials 363 377 +14 🚀 New features to boost your workflow:
|
|
@sonalgaud12, are you able to address the comments? |
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
|
@sonalgaud12, are you able to address @XSAM's comments? |
|
Need approval from @codeboten @MrAlias |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sonalgaud12
This PR fixes #6821
Added test for prometheusReader function for both v0.3.0 & v0.2.0
Locally tested