-
Notifications
You must be signed in to change notification settings - Fork 46
Add support for _msearch, _bulk and _doc operations #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
- Coverage 55.09% 55.08% -0.02%
==========================================
Files 251 251
Lines 21477 21475 -2
==========================================
- Hits 11833 11829 -4
- Misses 8828 8830 +2
Partials 816 816
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Forgot to mention, https://github.com/open-telemetry/opentelemetry-ebpf-instrumentation/blob/main/devdocs/features.md should be updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work, good to merge as soon as tests pass.
|
The shard-4 failure looks related, it's failing in the ES test. |
Let me investigate it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
|
Hi everyone, I've been doing some research on the tests that fail. |
edit: we are still looking for the root cause |
…ements Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
994b416 to
f0d594a
Compare
I'm good with that plan, let's disable the test if you'd like and continue on another PR. |
|
I can also take a look at the BPF logs to see if anything is weird, unix_stream_sendmsg should be triggering for unix socks, I wonder if another traffic somehow passes through there and it's impacting this code path. |
Hi @grcevski, my comment on the |
|
No problem, let me know what you want to do. I re-ran the test one more time to see if it passes and it failed again in the same spot. I haven't had time today to look into it to see if I can spot the issue. I'm at a company offsite this week, but I'll try tomorrow. |
This PR continues the work done in #801 and it:
_msearch,_bulkand_docElasticsearch operations.extractDBQueryTextfunction: we just return the body and we don't check if it's a valid JSON because from an observability point of view it is still an Elasticsearch request/response. This way, we gain performance and provide the user with the query of the request.