-
Notifications
You must be signed in to change notification settings - Fork 849
feat: add on ending span processor functionality #6617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
85231aa to
e108c44
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6617 +/- ##
=======================================
Coverage 86.76% 86.76%
=======================================
Files 258 258
Lines 11958 11958
=======================================
Hits 10375 10375
Misses 1583 1583
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
This feature is still in development phase. It means that we cannot include it into stable releases for this package. You can make full search for Another thing for consideration: double check if it is not breaking change on binary level when you are introducing new class to the inheritance. |
This change creates a new ExtendedBaseProcessor that allows users to implement onEnding functionality to their processor, as per the spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#onending
|
I think I've appropriately added the OTEL1005 label where needed, could I get some help rerunning the workflows to see if there are any other remaining issues? And regarding the following, is there a way to do so besides just running the build/tests? Thanks in advance
|
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
Fixes: N/A
Design discussion issue: open-telemetry/opentelemetry-specification#4024
Changes
Changes based loosely on the same changes made to opentelemetry-java: open-telemetry/opentelemetry-java#6367
This change creates a new ExtendedBaseProcessor that allows users to implement onEnding functionality to their processor, as per the spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#onending
Specific changes:
CompositeProcessorto be extended from the newExtendedBaseProcessorto support processors that have OnEndingExtendedBaseProcessoras the place where this functionality is added, so as to not break any current experience of extending the normalBaseProcessorMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes