feat: add some type asserting validation function #1117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are 2 functions added in this commit: `validateEventNameOrNames()` and `validatePayload()` `validateEventNameOrNames()` validates either an array of event names or a string event name corresponds to known events `validatePayload()` validates the structure of the event object and also verifies the event name
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
|
These are fine for run-time checks, but fails on types. Typescript can't seem to infer the type properly |
nickfloyd
moved this from 👀 In review
to 🛑 Blocked/Awaiting Response
in 🧰 Octokit Active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 functions added in this commit:
validateEventNameOrNames()andvalidatePayload()validateEventNameOrNames()validates either an array of event names or a string event name corresponds to known eventsvalidatePayload()validates the structure of the event object and also verifies the event namePart of #1055
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!