-
Notifications
You must be signed in to change notification settings - Fork 939
feat(InputTime): new component #5302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
commit: |
60e4da6 to
dc8040f
Compare
β¦eFormField example
β¦us props and accessibility checks
β¦emove hideTimeZone section
β¦ponent structure and styling
|
@benjamincanac, you can take a look, there are two issues:
|
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
|
I think it can be removed, I'll do it tomorrow. |
β¦ structure and styling
|
@hywax So what I did is remove the Primitive (which was useless here since there is already
Let me know what you think! |
docs/app/components/content/examples/input-time/InputTimeFormFieldExample.vue
Show resolved
Hide resolved
|
@benjamincanac thank you very much! I will use your efforts in #5387 |
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
benjamincanac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hywax! π
|
Hey @hywax, just noticed when reviewing the InputDate component that only InputTime and InputNumber have a |
|
@benjamincanac Hi! When I was making |
π Linked issue
Resolves #3089
Closes #3969
β Type of change
π Description
TimeField, to have an option to create a time field instead of setting input type time.
Uses: https://reka-ui.com/docs/components/time-field as I saw usage of this in other components.
Also based styling and attributes based on the UInput
π Checklist