-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore(docs): Update codemod command for fs-truncate-fd-deprecation #8338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When I started migrating my project to the new LTS version, I encountered an error when executing this code mod. ```bash > npx codemod run @nodejs/fs-truncate-to-ftruncate [1/2] 🔍 Resolving package from registry: https://app.codemod.com ... Error: Registry error: Package not found: @nodejs/fs-truncate-to-ftruncate ``` Signed-off-by: Mikhail Garbuzov <madmxg@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates a codemod command reference in the migration guide from v22 to v24, changing the codemod identifier from @nodejs/fs-truncate-to-ftruncate to @nodejs/fs-truncate-fd-deprecation to align with the GitHub repository directory name.
- Updated the npx codemod command to use
@nodejs/fs-truncate-fd-deprecation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AugustinMauroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT !
fix link to codemod location Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> Signed-off-by: Mikhail Garbuzov <madmxg@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8338 +/- ##
=======================================
Coverage 76.71% 76.72%
=======================================
Files 118 118
Lines 9805 9822 +17
Branches 335 336 +1
=======================================
+ Hits 7522 7536 +14
- Misses 2281 2284 +3
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Description
When I started migrating my project to the new LTS version, I encountered an error when executing this codemod.
Validation
> npx codemod run @nodejs/fs-truncate-to-ftruncate [1/2] 🔍 Resolving package from registry: https://app.codemod.com ... Error: Registry error: Package not found: @nodejs/fs-truncate-to-ftruncateRelated Issues
No
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.