Skip to content

Make attributes case configurable. #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make attributes case configurable. #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65e8ea9
Make attributes case configurable.
m1n0 Feb 9, 2017
b3c9ef7
Apply the attributes case to relationships as well.
m1n0 Mar 3, 2017
65b9deb
Configurable attributes case for indented arrays and objects as well
m1n0 May 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/Helpers/DataAttributesHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,17 +72,22 @@ class DataAttributesHelper
/**
* @param \NilPortugues\Api\Mapping\Mapping[] $mappings
* @param array $array
* @param string $attributesCase
*
* @return array
*/
public static function setResponseDataAttributes(array &$mappings, array &$array)
public static function setResponseDataAttributes(array &$mappings, array &$array, string $attributesCase)
{
$attributes = [];
$type = $array[Serializer::CLASS_IDENTIFIER_KEY];
$idProperties = RecursiveFormatterHelper::getIdProperties($mappings, $type);

foreach ($array as $propertyName => $value) {
$keyName = self::transformToValidMemberName(RecursiveFormatterHelper::camelCaseToUnderscore($propertyName));
if ($attributesCase == 'snake_case') {
$propertyName = RecursiveFormatterHelper::camelCaseToUnderscore($propertyName);
}

$keyName = self::transformToValidMemberName($propertyName);

if (\in_array($propertyName, $idProperties, true)) {
self::addIdPropertiesInAttribute($mappings, $type, $keyName, $value, $attributes);
Expand All @@ -93,7 +98,11 @@ public static function setResponseDataAttributes(array &$mappings, array &$array
&& empty($mappings[$value[Serializer::CLASS_IDENTIFIER_KEY]])
) {
$copy = $value;
self::recursiveSetKeysToUnderScore($copy);

if ($attributesCase == 'snake_case') {
self::recursiveSetKeysToUnderScore($copy);
}

$attributes[$keyName] = $copy;
continue;
}
Expand Down
11 changes: 8 additions & 3 deletions src/Helpers/DataLinksHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public static function setResponseDataLinks(array &$mappings, array &$value)
*
* @return array
*/
public static function setResponseDataRelationship(array &$mappings, array &$array, array $parent)
public static function setResponseDataRelationship(array &$mappings, array &$array, array $parent, string $attributesCase)
{
$data = [JsonApiTransformer::RELATIONSHIPS_KEY => []];

Expand Down Expand Up @@ -109,7 +109,10 @@ public static function setResponseDataRelationship(array &$mappings, array &$arr
$href = \str_replace($idProperties, $idValues, $selfLink);
if ($selfLink != $href) {
$propertyNameKey = DataAttributesHelper::transformToValidMemberName($propertyName);
$propertyNameKey = self::camelCaseToUnderscore($propertyNameKey);

if ($attributesCase == 'snake_case') {
$propertyNameKey = RecursiveFormatterHelper::camelCaseToUnderscore($propertyNameKey);
}

$newData[JsonApiTransformer::RELATIONSHIPS_KEY][$propertyNameKey][JsonApiTransformer::LINKS_KEY][JsonApiTransformer::SELF_LINK][JsonApiTransformer::LINKS_HREF] = $href;
}
Expand All @@ -119,7 +122,9 @@ public static function setResponseDataRelationship(array &$mappings, array &$arr

if (!empty($newData[JsonApiTransformer::RELATIONSHIPS_KEY][$propertyName])) {
$propertyNameKey = DataAttributesHelper::transformToValidMemberName($propertyName);
$propertyNameKey = self::camelCaseToUnderscore($propertyNameKey);
if ($attributesCase == 'snake_case') {
$propertyNameKey = RecursiveFormatterHelper::camelCaseToUnderscore($propertyNameKey);
}

if (!empty($d[Serializer::CLASS_IDENTIFIER_KEY])) {
$type = $d[Serializer::CLASS_IDENTIFIER_KEY];
Expand Down
4 changes: 2 additions & 2 deletions src/JsonApiTransformer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,9 @@ protected function serialization(array &$value)
$data = [
self::DATA_KEY => \array_merge(
PropertyHelper::setResponseDataTypeAndId($this->mappings, $value),
DataAttributesHelper::setResponseDataAttributes($this->mappings, $value),
DataAttributesHelper::setResponseDataAttributes($this->mappings, $value, $this->attributesCase),
DataLinksHelper::setResponseDataLinks($this->mappings, $value),
DataLinksHelper::setResponseDataRelationship($this->mappings, $value, $value)
DataLinksHelper::setResponseDataRelationship($this->mappings, $value, $value, $this->attributesCase)
),
];

Expand Down