Skip to content

Conversation

@dhurley
Copy link
Collaborator

@dhurley dhurley commented Nov 5, 2025

Proposed changes

Add passthrough for gRPC connection when using a proxy. This is for scenarios where NGINX Agent has no internet access and can't resolve the hostname of the management server itself.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley requested a review from a team as a code owner November 5, 2025 17:03
@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.41%. Comparing base (012b734) to head (7abc12b).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/grpc/grpc.go 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1375      +/-   ##
==========================================
+ Coverage   86.28%   86.41%   +0.12%     
==========================================
  Files         102      102              
  Lines       12572    12580       +8     
==========================================
+ Hits        10848    10871      +23     
+ Misses       1248     1231      -17     
- Partials      476      478       +2     
Files with missing lines Coverage Δ
internal/grpc/grpc.go 83.25% <92.30%> (+0.61%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 012b734...7abc12b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Akshay2191 Akshay2191 self-requested a review November 6, 2025 10:06
@dhurley dhurley merged commit 7d68b2c into main Nov 7, 2025
67 of 68 checks passed
@dhurley dhurley deleted the support-proxy-no-dns branch November 7, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants