Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test inclusion requirements
No new tests were added; this patch simply hardens the existing Junos cleaners. Verified with:
CONDA_NO_PLUGINS=true conda run -n suzieq pytest tests/unit/poller/worker/services/test_service.pyRelated Issue
Fixes #991
Description
SRX5600 devices (detected as
junos-es) return multi-routing-engine JSON and sometimes emit lists/None in interface and ARP data. The poller expected MX-style JSON and scalar fields, so it raisedKeyError,AttributeError, andTypeErrorwhile cleaning. This change reuses the QFX normalizer forjunos-es, normalises interfacetypevalues, and guards ARP entries withoutoif, allowing SRX firewalls to be parsed successfully.Type of change
New Behavior
junos-esdevices pull the QFX command/normalisation set, matching SRX multi-RE uptime output.typefields before lowercasing.oifvalues, defaulting to an empty string.Contrast to Current Behavior
oif.Discussion: Benefits and Drawbacks
Changes to the Documentation
Proposed Release Note Entry
Comments
CONDA_NO_PLUGINS=true conda run -n suzieq pytest tests/unit/poller/worker/services/test_service.pyDouble Check
developbranch.developbranch.--signoffapplied