Closes #20204: Introduce modular template components #20737
+1,955
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
changed the title
…ass for e.g. CommentsPanels, JSONPanel, etc.
…d inherit from base class
jeremystretch
requested review from
a team and
bctiemann
and removed request for
a team
bctiemann
reviewed
Nov 6, 2025
| Parameters: | ||
| accessor: The dotted path to the attribute being rendered (e.g. "site.region.name") | ||
| label: Human-friendly label for the rendered attribute | ||
| template_name: The name of the template to render |
There was a problem hiding this comment.
I'm not sure about these parameter signatures in __init__ for these classes and the ones in panels.py. Is template_name a valid thing to list as a parameter here when it isn't being consumed in __init__ and can't be set directly on the class at instantiation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #20204
dcimNote: I am still in the process of writing documentation for the components.
TODO