PCDLoader: read label by type/size; examples: Z-up fit view and label colors #32064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
That 40MB file is too big for the repo... Do you mind removing it from the PR? |
added 3 commits
October 20, 2025 12:54
…-based colors - Read label attribute using header-derived type and size in binary and binary_compressed Examples (webgl_loader_pcd.html): - Add Z-up handling and fit-view camera for Z-up datasets - Recreate OrbitControls per up-axis to avoid roll on pitch - Colorize points by integer label (deterministic HSL mapping) - Hide GUI color control when label-based vertex colors are present - Keep legacy behavior for Y-up files; split file lists (yUpFiles/zUpFiles) - Update default example to 'binary/fusion_lidar_scene.pcd'
…tation - Set default example back to 'binary/Zaghetto.pcd' - Restore Y-up camera initial position to (0, 0, 1) - Revert OrbitControls maxDistance to 10 for Y-up path - Keep Z-up path logic for specific datasets (no visual baseline change) Lint: - PCDLoader.js: add missing semicolons for label reading (binary/binary_compressed) - webgl_loader_pcd.html: fix indentation to tabs (ESLint indent rule)
PreciousnessX
force-pushed
the
feature/pcdloader-label-zup
branch
from
e42a60a to
9f7d35f
Compare
|
Hi @mrdoob, Thanks for the feedback! ✅ File removed: I've removed the |
Mugen87
reviewed
Oct 20, 2025
| controls.update(); | ||
| camera.updateProjectionMatrix(); | ||
|
|
||
| } |
There was a problem hiding this comment.
Do you mind removing these changes from the demo and just add lidar_scene.pcd as a new asset?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
labelwhen its field size/type varies (1/2/4 bytes)Testing:
npm run lint,npm run test-unit,npm run test-unit-addonsColorize points by integer label (deterministic HSL mapping):
https://raw.githack.com/PreciousnessX/three.js/feature/pcdloader-label-zup/examples/webgl_loader_pcd.html