Skip to content

TSL: Automatic RTT if procedural input ​​are used in bumpMap() #31833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

TSL: Automatic RTT if procedural input ​​are used in bumpMap() #31833

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
503acfb
add convertToTexture
sunag Sep 5, 2025
40111f4
Update BumpMapNode.js
sunag Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/nodes/display/BumpMapNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import { uv } from '../accessors/UV.js';
import { normalView } from '../accessors/Normal.js';
import { positionView } from '../accessors/Position.js';
import { faceDirection } from './FrontFacingNode.js';
import { Fn, nodeProxy, float, vec2 } from '../tsl/TSLBase.js';
import { convertToTexture } from '../utils/RTTNode.js';
import { Fn, nodeObject, float, vec2 } from '../tsl/TSLBase.js';

// Bump Mapping Unparametrized Surfaces on the GPU by Morten S. Mikkelsen
// https://mmikk.github.io/papers3d/mm_sfgrad_bump.pdf
Expand Down Expand Up @@ -110,8 +111,8 @@ export default BumpMapNode;
*
* @tsl
* @function
* @param {Node<float>} textureNode - Represents the bump map data.
* @param {?Node<float>} [scaleNode=null] - Controls the intensity of the bump effect.
* @param {Node<vec3>} node - Represents the bump map data.
* @param {?Node<float>} [scale=null] - Controls the intensity of the bump effect.
* @returns {BumpMapNode}
*/
export const bumpMap = /*@__PURE__*/ nodeProxy( BumpMapNode ).setParameterLength( 1, 2 );
export const bumpMap = ( node, scale = null ) => new BumpMapNode( convertToTexture( node ), nodeObject( scale ) );
Loading