REP-6735 Allow rechecks to be enqueued during recheck task gen #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdq45gj
approved these changes
Nov 7, 2025
Collaborator
tdq45gj
left a comment
tdq45gj
left a comment
There was a problem hiding this comment.
LGTM % one small request
internal/verifier/recheck.go
Outdated
| generation++ | ||
|
|
||
| eg, groupCtx := contextplus.ErrGroup(ctx) | ||
| eg.SetLimit(100) |
Collaborator
There was a problem hiding this comment.
Could you add a comment to explain the purpose of the limit?
Collaborator
Author
|
There were test failures in the past run, but they are unrelated & will be dealt with separately. |
FGasper
deleted the
REP-6735-allow-recheck-enqueue-during-recheck-task-gen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, the verifier blocked the enqueuing of rechecks while generating new recheck tasks. This slowed down the change stream because it couldn’t enqueue rechecks during that time.
There seems to be no reason why the change stream needs to be blocked while creating new tasks, though. This changeset removes the restriction. It also tweaks the generation-numbering so that the generation persisted with the recheck is the generation where the document will be rechecked rather than the generation where the recheck was enqueued.
The net effect here is that, with the change stream not blocked for several seconds between generations, higher throughput is possible.